[buddypress-trac] [BuddyPress Trac] #6206: missing class name in notification table

[buddypress-trac]

#6206: missing class name in notification table
---------------------------------------+------------------------------
 Reporter:  danbp                      |       Owner:
     Type:  defect (bug)               |      Status:  new
 Priority:  normal                     |   Milestone:  Awaiting Review
Component:  Component - Notifications  |     Version:  2.2
 Severity:  normal                     |  Resolution:
 Keywords:                             |
---------------------------------------+------------------------------

Comment (by danbp):

 It's not wrong, but missing imho. The're 3 th in the excerpt.
 1) th class"icon"
 '''2) th <label class'''
 3) th class "title"

 A class name for this th can be usefull to define a width. Not sure if
 doing this for the label contained inside will be enough.
 And to be logic, why have the other th a class name and this one has none
 ?

 Normally, a cell takes up the space it needs to display the content. The
 width attribute is used to set a predefined width of a cell.

 But what is "normal" with CSS ?

 In english, this table cell contains "Select all". In other languages this
 string can be much longer, and maybe wraped into two lines, depending of
 the place where the table is used.

 According to the language used, there is actually a more or less long
 string above a column who contains only checkboxes.

 Personally i removed this string (but not the label to gain place and let
 fit the column to only the checkbox width. But this is my choice and not
 the reason of the ticket. ;-)

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6206#comment:2>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac