[buddypress-trac] [BuddyPress Trac] #6189: Query string in directory URL breaks AJAX pagination

[buddypress-trac]

#6189: Query string in directory URL breaks AJAX pagination
---------------------------------+-----------------------------
 Reporter:  dontdream            |      Owner:
     Type:  defect (bug)         |     Status:  new
 Priority:  normal               |  Milestone:  Awaiting Review
Component:  Component - Members  |    Version:
 Severity:  normal               |   Keywords:
---------------------------------+-----------------------------
 Steps to reproduce, with JavaScript enabled:

 1. Visit the Members Directory page with the URL:
 http://example.com/members/?foo=bar

 2. Check the pagination links, they are like


 {{{
 href='?upage=2'
 }}}

 3. Click one of the pagination links; the correct page is Ajax loaded

 4. Check the new pagination links, they are like


 {{{
 href='http://example.com/members/?foo=bar&upage=2'
 }}}


 5. If you click one of the new pagination links, an incorrect page is Ajax
 loaded.

 That happens because, when generating the pagination links, the
 BP_Core_Members_Template class constructor uses an empty string as $base
 if the page is not Ajax loaded, but uses the URL as $base if the page is
 Ajax loaded.

 That's usually harmless, but when the URL contains a query string it
 breaks the pagination.

 The attached patch removes this unnecessary difference in the Members,
 Groups and Messages directories.

 Note: a real use case for this happens with BP Profile Search, when the
 plugin search form uses the GET form method.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6189>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac