[buddypress-trac] [BuddyPress Trac] #4590: filter select options out of sync with parent tab

[buddypress-trac]

#4590: filter select options out of sync with parent tab
-----------------------------+-----------------------------
 Reporter:  modemlooper      |       Owner:
     Type:  defect (bug)     |      Status:  new
 Priority:  normal           |   Milestone:  Future Release
Component:  General - UX/UI  |     Version:  1.7
 Severity:  normal           |  Resolution:
 Keywords:  needs-patch      |
-----------------------------+-----------------------------
Changes (by lakrisgubben):

 * cc: alexander.berthelsen@… (added)


Comment:

 Testing this on trunk and 2015 it works as it should I think. For example:
 If I favorite a "new group created" activity in the stream and then filter
 favorites on "new groups" it shows up there (same goes for new post etc).

 On the mentions screen it seems a bit more strange to have these filter
 options though... One idea would be to change the context of
 bp_get_activity_show_filters() to 'mentions' when on the mentions screen
 as in attached patch. This would remove the default filter values while
 still letting plugins hook in and add new ones. Pros with this approach
 would be that we don't need to touch bp-legacy, the con is that the select
 box will still be visible but with only the 'everything' option
 available...

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4590#comment:3>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac