[buddypress-trac] [BuddyPress Trac] #6765: Use WP page names for BP directory pages headings

[buddypress-trac]

#6765: Use WP page names for BP directory pages headings
---------------------------------+------------------
 Reporter:  hnla                 |       Owner:
     Type:  enhancement          |      Status:  new
 Priority:  normal               |   Milestone:  2.5
Component:  Component - Any/All  |     Version:
 Severity:  normal               |  Resolution:
 Keywords:  has-patch            |
---------------------------------+------------------
Changes (by hnla):

 * keywords:  needs-patch => has-patch


Comment:

 Initial '01' patch adds the check for `bp_core_get_directory_pages()` to
 the conditionals ahead of `buddypress()->{$component}->directory_title`

 This works to use the WP Page name as found in
 wp_cache_get('directory_pages', 'bp_pages')if that cache is empty BP
 builds it from a wpdb query on posts. This feels as though it would be all
 that's required to set the display header title and wp_title, I've left
 the original series of checks in place so we fallback to using
 `buddypress()->{$component}->directory_title` as set in
 `bp-{component}-loader.php setup_globals()` args.

 At this stage not tested is what occurs when we activate BP for the first
 time and create our initial BP dir WP Pages, but it reads to me as though
 there ought not to be problems here we'll create the pages before we have
 need to query for the page title string.

 If this were simply included as is the consequence for existing sites
 would probably just be a change in the Activity component setup as this is
 the one component where we diverge from the page name we set in page
 creation and the name as set in setup_globals() 'Activity' Vs. 'Site-Wide
 Activity' display would change to 'Activity' unless the WP Page name had
 been changed. While not advocating we change sites display necessarily if
 we were to thinking through the process users would have to grapple with,
 at most, having to log into admin and update their page titles for the BP
 pages, developers that had gone to lengths to change BP's default beaviour
 with ? filters would likely not be affected, filtering on
 `bp_get_directory_title` would override the changes made here.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6765#comment:1>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac