[buddypress-trac] [BuddyPress Trac] #6586: New avatar uploader on mobile Safari broken

[buddypress-trac]

#6586: New avatar uploader on mobile Safari broken
---------------------------------+------------------------------
 Reporter:  modemlooper          |       Owner:  imath
     Type:  defect (bug)         |      Status:  assigned
 Priority:  normal               |   Milestone:  Awaiting Review
Component:  Component - Members  |     Version:  2.3.2
 Severity:  normal               |  Resolution:
 Keywords:  has-patch            |
---------------------------------+------------------------------
Changes (by imath):

 * keywords:  needs-testing => has-patch


Comment:

 Replying to [comment:1 modemlooper]:
 > only images from library work

 For me when taking an image using the camera does not crash at all !! See
 this screen capture :

 [[Image(https://farm1.staticflickr.com/459/19891433214_d3a8b6b170_b.jpg)]]

 > image taken in landscape has issue
 I'd say it depends if you are using your phone in landscape mode to set
 your avatar, because in this case, there's no issue: see previous screen
 capture and following one with the image you added on this ticket:

 [[Image(https://farm1.staticflickr.com/559/20327382849_7857aab9b7_b.jpg)]]

 There's only a problem when using the portrait mode to set an avatar, in
 this case the image is "cut off" on the right side.

 [[Image(https://farm6.staticflickr.com/5620/20505242392_993901fff1_b.jpg)]]

 So i've read your advices about this ticket #4859 (using a max width set
 to 280px). So i guess we could use this size in case of `wp_is_mobile()`
 and that's what i've done in 6586.patch, so in portrait mode we get:

 [[Image(https://farm1.staticflickr.com/486/19891433164_45a5175ea7_b.jpg)]]

 But then, in landscape mode, we have a big white space on the right...

 [[Image(https://farm1.staticflickr.com/566/20326033708_8953413793_b.jpg)]]

 So i think 6586.patch would solve the problem for this ticket and #4859.
 But i also think we could improve it by having two images at our disposal
 and choose within avatar.js which one to use depending on the available
 width of the browser. I'll keep on working on it soon.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6586#comment:3>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac