[buddypress-trac] [BuddyPress Trac] #6583: bp_friend_requests_item hook should have been inside <div class="item"> div

[buddypress-trac]

#6583: bp_friend_requests_item hook should have been inside <div class="item"> div
-------------------------------------+------------------
 Reporter:  pareshradadiya           |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  2.4
Component:  Component - Friends      |     Version:  1.7
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |
-------------------------------------+------------------

Comment (by hnla):

 I saw this yesterday - Yes essentially we have outputted friends items
 grouped inside a div then allow for additional items that fall outside of
 that group which on the face of it must be wrong.

 Only concern is if moving the hook would upset any existing actions but
 that's more likely to occur moving a hook outside of some existing scope,
 less likely devs would have written:
 ` .item + .my-hooked-items` but is possible!

 I would suggest we commit on the basis that it's unlikely to cause issues
 and always should have been inside the .item div not outside.

 We can and will add the change to the codex version template changes page.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6583#comment:3>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac