[buddypress-trac] [BuddyPress Trac] #6577: friends_check_friendship_status() problem when using legacy user query

[buddypress-trac]

#6577: friends_check_friendship_status() problem when using legacy user query
---------------------------------+---------------------
 Reporter:  r-a-y                |       Owner:  r-a-y
     Type:  defect (bug)         |      Status:  closed
 Priority:  normal               |   Milestone:  2.4
Component:  Component - Friends  |     Version:  2.1
 Severity:  normal               |  Resolution:  fixed
 Keywords:  has-patch            |
---------------------------------+---------------------
Changes (by r-a-y):

 * owner:   => r-a-y
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"10037"]:
 {{{
 #!CommitTicketReference repository="" revision="10037"
 Friends: Fix issue with using `friends_check_friendship_status()` during
 the members loop when the legacy user query is enabled.

 Previously, if the legacy user query was enabled, the friendship button in
 the members loop would always return "Add Friend" regardless of the actual
 friendship status.

 This commit fixes this by setting the `'not_friends'` status inside the
 the `bp_friends_filter_user_query_populate_extras()` function instead of
 in `friends_check_friendship_status()`.

 Fixes #6577.
 }}}

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6577#comment:2>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac