[buddypress-trac] [BuddyPress Trac] #6487: Mentions.js fails on wp-admin post editor

buddypress-trac noreply at wordpress.org
Thu Aug 6 17:55:39 UTC 2015


#6487: Mentions.js fails on wp-admin post editor
----------------------------------+--------------------
 Reporter:  dcavins               |       Owner:
     Type:  defect (bug)          |      Status:  new
 Priority:  normal                |   Milestone:  2.3.3
Component:  Component - Activity  |     Version:  2.3.1
 Severity:  normal                |  Resolution:
 Keywords:  has-patch             |
----------------------------------+--------------------

Comment (by imath):

 @dcavins i had a look at your patch, the fix is working fine, great work
 :)

 I have some suggestions about how all this is organized:
 - i think we should only load the "tinymce" part if the editor has tinymce
 available, so using the action `wp_enqueue_editor` can help us to get this
 information.
 - As a result, i suggest to put your fix in a specific file >
 `mentions.tinymce.js`
 - it may not be directly relative to this ticket, but i needed to register
 the 'bp-mentions' script into wp scripts so i've added a bunch of
 functions to use the core-cssjs functions that are pretty helpful.

 All these suggestions are available in 6487.03.patch

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6487#comment:8>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list