[buddypress-trac] [BuddyPress Trac] #6570: Add UI for adding Profile Header Images for Users and Groups
buddypress-trac
noreply at wordpress.org
Wed Aug 5 19:06:50 UTC 2015
#6570: Add UI for adding Profile Header Images for Users and Groups
--------------------------+------------------
Reporter: mercime | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: 2.4
Component: API | Version:
Severity: normal | Resolution:
Keywords: dev-feedback |
--------------------------+------------------
Comment (by r-a-y):
Thanks imath as always for your quick turnarounds :)
This is pretty much what I had in mind. A pity that WordPress defaults to
`true` for `current_theme_supports()`.
----
Replying to [https://buddypress.trac.wordpress.org/ticket/6570#comment:21
modemlooper]:
> I 100% disagree we should only support core theme's and if this is the
case it should never go into BuddyPress core.
Replying to [https://buddypress.trac.wordpress.org/ticket/6570#comment:24
johnjamesjacoby]:
> I feel strongly against using add_theme_support. If we build this as a
core feature that themes can support, either they support it or they
don't; no additional declaration required. And bp-legacy shouldn't need to
declare support for anything since it should come with everything.
imath's reply (comment:22) is exactly why I mention that we should only
add support on themes that we have companion stylesheets for.
The alternative is to offer a "tamer" version of the cover photo that
works on every theme, which I do not think people will like as a default
feature.
However, if we can get the markup to a point where the cover photo looks
consistent without any weird design quirks, then we can think about
rolling with it.
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6570#comment:26>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac
More information about the buddypress-trac
mailing list