[buddypress-trac] [BuddyPress Trac] #6570: Add UI for adding Profile Header Images for Users and Groups

[buddypress-trac]

#6570: Add UI for adding Profile Header Images for Users and Groups
--------------------------+------------------
 Reporter:  mercime       |       Owner:
     Type:  enhancement   |      Status:  new
 Priority:  normal        |   Milestone:  2.4
Component:  API           |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  dev-feedback  |
--------------------------+------------------

Comment (by johnjamesjacoby):

 I feel strongly against using add_theme_support. If we build this as a
 core feature that themes can support, either they support it or they
 don't; no additional declaration required. And bp-legacy shouldn't need to
 declare support for anything since it should come with everything.

 Imath, your screenshots look basically perfect IMO. If you've got it
 looking and working well in all of those themes, that's ideal.

 In general, it seems most cover photo UI's do not include cropping, and
 instead include a placement mechanism to center or align an image, so that
 it can flex along with changes in height and width. If we crop it to
 explicit dimensions, we risk exposing an empty background area. I suppose
 we can crop & compress for compliance sake inside of our API, but I
 haven't seen a cover photo UI that cropped, and I have a hunch that
 responsive design and being flexible is the reason.

 Imath, can you help me better understand why this will not work without
 add_theme_support? It's possible I don't understand what problem it solves
 for us, but I've always thought of it as a backwards and generally useless
 API that promotes lock-in vs. providing compatibility and flexibility.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6570#comment:24>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac