[buddypress-trac] [BuddyPress Trac] #4677: Option to disable Group avatars

[buddypress-trac]

#4677: Option to disable Group avatars
--------------------------------------------------+------------------
 Reporter:  sooskriszta                           |       Owner:
     Type:  enhancement                           |      Status:  new
 Priority:  low                                   |   Milestone:  2.3
Component:  Component - Groups                    |     Version:
 Severity:  minor                                 |  Resolution:
 Keywords:  has-patch dev-feedback needs-testing  |
--------------------------------------------------+------------------

Comment (by imath):

 Replying to [comment:23 boonebgorges]:

 Great!

 > - Instead of falling back on `false` when no value has been saved for
 'bp-disable-group-avatar-uploads', fall back on the value of the general
 'bp-disable-avatar-uploads'. This is for backward compatibility: anyone
 who currently has avatars disabled across the site will expect them to be
 disabled after upgrade.

 Absolutely

 > - I added a very slight change to the stylesheet to make things look
 decent on group directories without avatars. This involves adding the
 'group-no-avatar'/'group-has-avatar' class. This is kinda ugly, but it's
 the only way I could think of doing it without template-level mods.

 Group descriptions are best aligned, great.

 > It'd be nice to get a second set of eyes on this.

 Suggestions :

 - I think you should carry on disallowing group avatars if the 'Show
 avatars' WordPress setting is not available, else it could be a regression
 of what we've fixed in 2.1 see #5345
 - I think we shouldn't display the activity secondary avatar if the avatar
 are not allowed for groups. Else, i find it weird to have the mystery man
 in 'imath posted an update in [mystery man] group'.
 - I think you forgot the Group Profile Photo create step in `bp-groups-
 loader.php`.
 - Even if there's no chance the Avatar UI would load, i think i'd feel
 better if we could use your new function. Else, i'll simply commit a
 change (using `true`) on #6290 about `bp_avatar_is_front_edit()` because
 unlike the user profile photo, the group profile photo screen is never
 displayed in this case as no gravatar service is available for groups.

 4677.4.patch = 4677.3.patch + the above suggestions.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4677#comment:25>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac