[buddypress-trac] [BuddyPress Trac] #6368: Use proper plural forms in languages with more than two forms

buddypress-trac noreply at wordpress.org
Fri Apr 17 01:50:39 UTC 2015


#6368: Use proper plural forms in languages with more than two forms
---------------------------+------------------------------
 Reporter:  netweb         |       Owner:
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  Awaiting Review
Component:  Locale - i18n  |     Version:
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |
---------------------------+------------------------------
Changes (by SergeyBiryukov):

 * keywords:  needs-patch => has-patch


Comment:

 Replying to [comment:2 boonebgorges]:
 > Does that seem right to others?

 That pattern looks correct, yes. That's what we use in core now.

 I've reviewed all other uses of `_n()` and fixed the affected instances.
 Also fixed another issue with those strings: `_n()` show receive an
 integer (e.g. `$blogs_template->total_blog_count`) as its third argument,
 not a string returned by `bp_core_number_format()` (e.g. `$total`).

 Would appreciate a second pair of eyes to make sure there are no
 copy/paste errors.

 The second patch is for bbPress external. Not sure if it's still used or
 supported anymore. Should the patch be submitted to
 [https://bbpress.trac.wordpress.org/ bbPress Trac]? Attached it here for
 reference.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6368#comment:3>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list