[buddypress-trac] [BuddyPress Trac] #4677: Option to disable Group avatars

[buddypress-trac]

#4677: Option to disable Group avatars
--------------------------------------------------+------------------
 Reporter:  sooskriszta                           |       Owner:
     Type:  enhancement                           |      Status:  new
 Priority:  low                                   |   Milestone:  2.3
Component:  Component - Groups                    |     Version:
 Severity:  minor                                 |  Resolution:
 Keywords:  has-patch dev-feedback needs-testing  |
--------------------------------------------------+------------------
Changes (by boonebgorges):

 * milestone:  Future Release => 2.3


Comment:

 Replying to [comment:21 sooskriszta]:
 > Replying to [comment:20 boonebgorges]:
 > > if you turn off group avatars, you should remove the avatars from the
 templates altogether.
 > I think that's what the patch does, though the UI language is sketchy
 and unclear.

 Yeah, I guess you're right - we already do this when avatars are disabled
 altogether. My apologies for misreading.

 [attachment:4677.3.patch] makes a few revisions:

 - Instead of falling back on `false` when no value has been saved for 'bp-
 disable-group-avatar-uploads', fall back on the value of the general 'bp-
 disable-avatar-uploads'. This is for backward compatibility: anyone who
 currently has avatars disabled across the site will expect them to be
 disabled after upgrade.
 - I added a very slight change to the stylesheet to make things look
 decent on group directories without avatars. This involves adding the
 'group-no-avatar'/'group-has-avatar' class. This is kinda ugly, but it's
 the only way I could think of doing it without template-level mods.
 - General cleanup

 It'd be nice to get a second set of eyes on this.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4677#comment:23>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac