[buddypress-trac] [BuddyPress Trac] #6230: BP 2.2 (and 2.2.1) feed is no longer protected by Wishlist Member

[buddypress-trac]

#6230: BP 2.2 (and 2.2.1)  feed is no longer protected by Wishlist Member
-----------------------------------------+---------------------------------
 Reporter:  Pete Hudson                  |       Owner:
     Type:  defect (bug)                 |      Status:  new
 Priority:  normal                       |   Milestone:  Under
Component:  Appearance                   |  Consideration
 Severity:  normal                       |     Version:  2.2.1
 Keywords:  reporter-feedback has-patch  |  Resolution:
-----------------------------------------+---------------------------------

Comment (by r-a-y):

 I think there are three approaches we could take:

 * Leave all BP pages as page ID zero (current method)
 * Move back all BP pages to the corresponding BP directory page ID
 * Use page ID zero on BP single pages only

 The first option is what we're currently using now.  It sets us up for
 rewrite rules and virtual pages in the future, but breaks functionality
 with plugins such as WLM expecting a proper WP page and those using
 `is_page()` (the `is_page()` issue is fixed in WP 4.2-bleeding).

 The second option is what we were using up until BP 2.1.1.  The problem
 here is if someone is using WP functions like `get_queried_object()` or
 `the_permalink()` on a BP single page, this would reference the WP page
 properties instead.  This offers the most compatibility, but edge cases
 can occur (`is_page()` and plugins doing stuff dependent on WP
 properties).  This is basically r8932 (or a version of mikelopez's patch).

 `6230.reset-single-pages.patch` implements the third option, which adds
 back r8821.  It resets the post on single pages (`/members/USER/`,
 `/groups/GROUP/`), but not directory pages (`/members/`, `/groups/`,
 etc.).

 This is what I originally envisioned in r8821 as a BP directory page is
 technically a WP page, but a BP single page is a virtual page.  Due to
 issues with page highlighting (#5810), we had to revert r8821, but this
 should be fixed as of r9322.  When WLM is used with this patch, BP
 directory pages can be blocked again, however BP single pages will not.
 So this could be seen as a half-measure for those using WP plugins like
 WLM with BuddyPress.

 You can also view some discussion on Slack about the page ID zero
 situation here:
 https://wordpress.slack.com/archives/buddypress/p1424375799002601

 All of these approaches are valid, but also have issues.  If we care about
 plugin compatibility, then we should go back to the second option with the
 caveat that we'll have to do this all over again in the future.  If we are
 planning on implementing rewrite rules in an upcoming release (v2.3 or
 v2.4), then we should stick with what we're using currently.  Technically,
 the third option makes sense as well.

 Feedback welcome.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6230#comment:15>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac