[buddypress-trac] [BuddyPress Trac] #6353: BuddyPress navigation appends a trailing slash to the link in a subnav item when link is forced

[buddypress-trac]

#6353: BuddyPress navigation appends a trailing slash to the link in a subnav item
when link is forced
------------------------------+--------------------
 Reporter:  pareshradadiya    |       Owner:
     Type:  defect (bug)      |      Status:  new
 Priority:  normal            |   Milestone:  2.3
Component:  Component - Core  |     Version:  2.2.1
 Severity:  normal            |  Resolution:
 Keywords:  has-patch         |
------------------------------+--------------------

Comment (by boonebgorges):

 In [changeset:"9701"]:
 {{{
 #!CommitTicketReference repository="" revision="9701"
 Don't trailingslash the href of subnav items if the 'link' was provided
 explicitly in `bp_core_new_subnav_item()`.

 `trailingslashit()` is not smart enough to detect links with query params,
 so
 that links can be improperly trailingslashed in some cases. More
 generally,
 it's not the case that all links should be trailingslashed (in particular,
 those that do not lead to WP/BP pages), so plugin authors should be
 responsible
 for trailingslashing on their own.

 Props pareshradadiya.
 See #6353.
 }}}

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6353#comment:4>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac