[buddypress-trac] [BuddyPress Trac] #6348: BP Theme Compat: Administration screens & control

buddypress-trac noreply at wordpress.org
Mon Apr 6 09:57:47 UTC 2015


#6348: BP Theme Compat: Administration screens & control
--------------------------------+------------------
 Reporter:  imath               |       Owner:
     Type:  enhancement         |      Status:  new
 Priority:  normal              |   Milestone:  2.3
Component:  API - Theme Compat  |     Version:  1.7
 Severity:  normal              |  Resolution:
 Keywords:  has-patch           |
--------------------------------+------------------

Comment (by imath):

 Thanks a lot DJPaul.

 I'd say we can do it of course. But then, we'd need to do it in all the
 backbone templates if we want to make sure to get the templates from bp-
 legacy.

 Using 'bp_get_restrained_template_part()' allow us to keep on using the
 regular bp_get_template_part() in the child template parts. So i guess, i
 found it easier when we are more secure about a template part to remove
 '_restrained' at the top template than to edit each templates.

 Then if we don't have  'bp_get_restrained_template_part()' and the part
 i'm changing in `bp_locate_template()`:
 using require into the top template from the administration screens
 wouldn't work if the child templates are using bp_get_template_part().

 Finally i find it less elegant :)

 But if we plan to never let these templates being overridable i'd say
 you're absolutely right, else i'd say i'd like to have @jjj's opinion :)

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6348#comment:4>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list