[buddypress-trac] [BuddyPress Trac] #6351: Add Grunt task to llint SCSS files

buddypress-trac noreply at wordpress.org
Sun Apr 5 07:26:22 UTC 2015


#6351: Add Grunt task to llint SCSS files
-----------------------------------+------------------
 Reporter:  netweb                 |       Owner:
     Type:  enhancement            |      Status:  new
 Priority:  normal                 |   Milestone:  2.3
Component:  Tools - Build Process  |     Version:
 Severity:  normal                 |  Resolution:
 Keywords:  needs-patch            |
-----------------------------------+------------------

Comment (by netweb):

 Using 6351.03.diff gets us very close, the below is the result of running
 `grunt scsslint` for `twentyfifteen.scss`

 {{{
 $ grunt scsslint
 Running "scsslint:core" (scsslint) task
 Running scss-lint on core
 src/bp-templates/bp-legacy/css/twentyfifteen.scss:31 [W] NameFormat: Name
 of variable `RemFontValue` should be written in all lowercase letters with
 hyphens instead of underscores
 src/bp-templates/bp-legacy/css/twentyfifteen.scss:33 [W]
 DuplicateProperty: Property `font-size` already defined on line 32
 src/bp-templates/bp-legacy/css/twentyfifteen.scss:33 [W] NameFormat: Name
 of variable `RemFontValue` should be written in all lowercase letters with
 hyphens instead of underscores
 src/bp-templates/bp-legacy/css/twentyfifteen.scss:169 [W] ColorVariable:
 Color literals like `#555` should only be used in variable declarations;
 they should be referred to via variable everywhere else.
 src/bp-templates/bp-legacy/css/twentyfifteen.scss:170 [W] ColorVariable:
 Color literals like `#fff` should only be used in variable declarations;
 they should be referred to via variable everywhere else.
 src/bp-templates/bp-legacy/css/twentyfifteen.scss:179 [W] ColorVariable:
 Color literals like `#eee` should only be used in variable declarations;
 they should be referred to via variable everywhere else.
 src/bp-templates/bp-legacy/css/twentyfifteen.scss:180 [W] ColorVariable:
 Color literals like `#ddd` should only be used in variable declarations;
 they should be referred to via variable everywhere else.
 src/bp-templates/bp-legacy/css/twentyfifteen.scss:209 [W] ColorVariable:
 Color literals like `#F2F2F2` should only be used in variable
 declarations; they should be referred to via variable everywhere else.
 src/bp-templates/bp-legacy/css/twentyfifteen.scss:209 [W] HexNotation:
 Color `#F2F2F2` should be written as `#f2f2f2`
 src/bp-templates/bp-legacy/css/twentyfifteen.scss:214 [W] ColorVariable:
 Color literals like `#fff` should only be used in variable declarations;
 they should be referred to via variable everywhere else.
 src/bp-templates/bp-legacy/css/twentyfifteen.scss:241 [W] ColorVariable:
 Color literals like `#555` should only be used in variable declarations;
 they should be referred to via variable everywhere else.
 src/bp-templates/bp-legacy/css/twentyfifteen.scss:242 [W] ColorVariable:
 Color literals like `#fff` should only be used in variable declarations;
 they should be referred to via variable everywhere else.
 src/bp-templates/bp-legacy/css/twentyfifteen.scss:261 [W] ColorVariable:
 Color literals like `#eee` should only be used in variable declarations;
 they should be referred to via variable everywhere else.
 src/bp-templates/bp-legacy/css/twentyfifteen.scss:265 [W] ColorVariable:
 Color literals like `#fff` should only be used in variable declarations;
 they should be referred to via variable everywhere else.
 src/bp-templates/bp-legacy/css/twentyfifteen.scss:269 [W] ColorVariable:
 Color literals like `#ddd` should only be used in variable declarations;
 they should be referred to via variable everywhere else.
 src/bp-templates/bp-legacy/css/twentyfifteen.scss:282 [W] SelectorDepth:
 Selector should have depth of applicability no greater than 5, but was 6
 src/bp-templates/bp-legacy/css/twentyfifteen.scss:292 [W] ColorVariable:
 Color literals like `#ddd` should only be used in variable declarations;
 they should be referred to via variable everywhere else.
 src/bp-templates/bp-legacy/css/twentyfifteen.scss:358 [W] ImportantRule:
 !important should not be used
 src/bp-templates/bp-legacy/css/twentyfifteen.scss:462 [W] ColorVariable:
 Color literals like `#ccc` should only be used in variable declarations;
 they should be referred to via variable everywhere else.
 src/bp-templates/bp-legacy/css/twentyfifteen.scss:484 [W] ColorVariable:
 Color literals like `#ccc` should only be used in variable declarations;
 they should be referred to via variable everywhere else.
 src/bp-templates/bp-legacy/css/twentyfifteen.scss:505 [W] ImportantRule:
 !important should not be used
 Warning: Task "scsslint:core" failed. Use --force to continue.

 Aborted due to warnings.
 }}}

 Just a matter of tweaking the remaining rules or updating the code the
 reflect the SCSS-Lint rules.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6351#comment:3>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list