[buddypress-trac] [BuddyPress Trac] #6342: Improve XProfile field visibility labels

[buddypress-trac]

#6342: Improve XProfile field visibility labels
----------------------------------+------------------
 Reporter:  johnjamesjacoby       |       Owner:
     Type:  enhancement           |      Status:  new
 Priority:  high                  |   Milestone:  2.3
Component:  Component - XProfile  |     Version:
 Severity:  minor                 |  Resolution:
 Keywords:  2nd-opinion           |
----------------------------------+------------------

Comment (by boonebgorges):

 > I'd rather not litter the codebase with bespoke approaches to solving
 the same central verbiage problem. In fact, in the past we've done our
 best to avoid & clean these usages up IIRC.

 I disagree that it's "littering the codebase", but as you note it's an
 argument for another ticket.

 Your screenshot is helpful in showing your motivation for the changes: in
 your custom theme, you've removed the "Who can see this field?" question,
 and the implicit question is "What is the visibility level of this
 field?", so your suggestions make sense. In the context of BP more
 generally, we need to be consistent: either the labels should describe the
 audience, or they should describe the fields, and the question/prompt
 should match. If we go with the change in grammatical orientation, I would
 suggest: "Public", "Members Only", "Friends Only", "Private". "All
 Members" is not an adjectival phrase and so is not parallel, and "Only
 Self" is very awkward IMHO. (Bonus: this phrasing works equally well in
 the first and third person.) The fieldset legend would then have to be
 something like: "Field visibility" or maybe just "Visibility".

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6342#comment:6>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac