[buddypress-trac] [BuddyPress Trac] #3794: Deleted activity items remain favourited

[buddypress-trac]

#3794: Deleted activity items remain favourited
--------------------------+--------------------
 Reporter:  ewebber       |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  2.2
Component:  Activity      |     Version:  1.5.1
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+--------------------

Comment (by DJPaul):

 > If i have a user meta set to 3, and any random activity is deleted, then
 we would need to do another query to look for each user who favorited the
 activity and update the count for each user

 I don't think this is a blocker problem. We couldn't do this before
 because each user's list of favourites topics was stored in the
 `bp_favorite_activities` usermeta (a serialized array); the proposed
 solution lets us do this now.

 ---

 I am going to thinking more about the merits of using a separate DB table
 (apart from possible performance improvements that you and Boone
 discovered). It's not the first time the idea of a many-to-many
 relationships table has come up; see Ray's first suggestion in #5665.
 (pretty sure there might be another ticket where a new table is a proposed
 solution for some other problem, but trac ticket search is crap).

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/3794#comment:18>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac