[buddypress-trac] [BuddyPress Trac] #5909: Logging out does not clear cookies

[buddypress-trac]

#5909: Logging out does not clear cookies
---------------------------+--------------------
 Reporter:  r-a-y          |       Owner:
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  2.1.1
Component:  Template Pack  |     Version:  2.1
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |
---------------------------+--------------------
Description changed by r-a-y:

Old description:

> Originally reported by Ypswytch:
> https://buddypress.trac.wordpress.org/ticket/5889#comment:13
>
> When a user logs out, buddypress.js attempts to clear all cookies.
> However, this now fails with BP 2.1.
>
> The problem is when we enqueued our JS assets, we upgraded jquery.cookie
> to 1.4.1.
>
> v1.4.1 uses a new has a new routine to [https://github.com/carhartl
> /jquery-cookie#usage remove cookies]:
> `$.removeCookie('name', { path: '/' });`
>
> We are currently doing this:
> `$.cookie('name', null, { path: '/' });`
>
> Which doesn't clear the cookie anymore.  Attached patch switches all our
> clear cookie calls to this updated routine.

New description:

 Originally reported by Ypswytch:
 https://buddypress.trac.wordpress.org/ticket/5889#comment:13

 When a user logs out, buddypress.js attempts to clear all cookies.
 However, this now fails with BP 2.1.

 The problem is when we enqueued our JS assets, we upgraded jquery.cookie
 to 1.4.1.

 v1.4.1 has a new routine to [https://github.com/carhartl/jquery-
 cookie#usage remove cookies]:
 `$.removeCookie('name', { path: '/' });`

 We are currently doing this:
 `$.cookie('name', null, { path: '/' });`

 Which doesn't clear the cookie anymore.  Attached patch switches all our
 clear cookie calls to this updated routine.

--

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5909#comment:2>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac