[buddypress-trac] [BuddyPress Trac] #5336: Add "manage invitations" pane to group admin screen

buddypress-trac noreply at wordpress.org
Sat Sep 27 02:07:29 UTC 2014

#5336: Add "manage invitations" pane to group admin screen
 Reporter:  dcavins                        |       Owner:
     Type:  enhancement                    |      Status:  new
 Priority:  normal                         |   Milestone:  2.2
Component:  Groups                         |     Version:  1.9.1
 Severity:  normal                         |  Resolution:
 Keywords:  has-patch early needs-refresh  |
Changes (by boonebgorges):

 * keywords:  has-patch early => has-patch early needs-refresh


 dcavins - Thanks for your patience as we review this patch.

 A few comments:

 - You note that it's not possible to resend invitations because our
 functions for doing so are linked to the logged-in user. Which functions
 are you talking about? (your link to trunk doesn't work because line
 numbers are changed :) ) If appropriate, we can and should either make the
 existing functions more flexible or create new ones. Please feel free to
 roll that in as part of this patch, or open a separate ticket for it.

 - Bulk management interface. You've gone with radio buttons for handling
 these invitations, with the processing taking place when you click "Save
 Changes". IMO this is a bit clunky. Better would be to have "Send" and
 "Remove" links - links which would refresh the page (unless you built AJAX
 support for them, which would be nice but wouldn't have to be part of v1).
 In addition, you could have checkboxes and a bulk action dropdown, similar
 to what we see on Dashboard > Posts. (I am aware that you were probably
 trying to keep parity with the "Manage Members" interface. But (a) that
 interface is less than stellar, and (b) the dropdowns in the right column
 refer to user status, *not* to actions/verbs, so the choice of a
 radio/dropdown is more semantic in that case.)

 - I see that you have copied the terrible
 `bp_groups_admin_create_pagination_links()` function. I don't remember
 what I was thinking when I wrote that it will be deprecated soon. But in
 any case, instead of reproducing just so we can have slightly different
 text, could you please add the necessary parameters (maybe passed as part
 of an `$args` array in the third param position) necessary to make this
 function usable for your pagination?

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5336#comment:19>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list