[buddypress-trac] [BuddyPress Trac] #5898: Unable to page through search results

[buddypress-trac]

#5898: Unable to page through search results
------------------------------------+--------------------
 Reporter:  bomako                  |       Owner:
     Type:  defect (bug)            |      Status:  new
 Priority:  normal                  |   Milestone:  2.1.1
Component:  Members                 |     Version:  2.1
 Severity:  normal                  |  Resolution:
 Keywords:  dev-feedback has-patch  |
------------------------------------+--------------------

Comment (by boonebgorges):

 > except for @ticket BP5898 as for some weird reason, the test is skipped
 in this case. So i've used @ticket bp5898 instead.

 This is by design - tests that are associated with open tickets are
 skipped, unless (a) you run them explicitly (`phpunit --group BP5898`) or
 (b) you define `WP_TESTS_FORCE_KNOWN_BUGS` as true in wp-tests-config.php.
 The fact that the test was being skipped when running `phpunit` means that
 you had the annotation correct :)

 Also, forgot to mention in my last comment - don't check `! empty(
 $matches[1] )`. You're doing that to avoid PHP notices, which is good
 practice in BuddyPress, but in a unit test, we want to see the error when
 your regex doesn't match anything so we know that the test has failed!

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5898#comment:6>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac