[buddypress-trac] [BuddyPress Trac] #5875: bp_activity_add to have a throttle time arg

buddypress-trac noreply at wordpress.org
Thu Sep 25 18:01:58 UTC 2014


#5875: bp_activity_add to have a throttle time arg
-------------------------+------------------------------
 Reporter:  SGr33n       |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  Awaiting Review
Component:  Core         |     Version:
 Severity:  normal       |  Resolution:
 Keywords:               |
-------------------------+------------------------------

Comment (by r-a-y):

 `01.patch` is a patch based from SGr33n's entire file upload.

 I like the idea of throttling.

 However, I do see one major UX problem.  Let's say `bp_activity_add()`
 returns false because it was throttled, how do we notify the user of this?
 We currently do not use `WP_Error` so we cannot determine what type of
 problem that `bp_activity_add()` returns.

 Switching to `WP_Error` might be beneficial in the long run, but we've
 been using boolean return values for so long that a change might break a
 few things.

 ---

 >  I was thinking that also other activities, like New Avatar should have
 a throttle time... could also happen that an user is trying more than one
 Avatar, so multiple activity actions will added on his activity, but other
 users just need to know about the last one.

 If multiple activity items are being added when a user uploads a new
 avatar each time, then this seems like a bug to me.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5875#comment:1>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list