[buddypress-trac] [BuddyPress Trac] #5887: Custom language file does not load in bp_core_load_buddypress_textdomain()

[buddypress-trac]

#5887: Custom language file does not load in bp_core_load_buddypress_textdomain()
--------------------------+-----------------------
 Reporter:  r-a-y         |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  2.1.1
Component:  Core          |    Version:
 Severity:  normal        |   Keywords:  has-patch
--------------------------+-----------------------
 WP now handles language pack downloads.

 Let's say a language pack is downloaded and used for BP, the latter
 section in `bp_core_load_buddypress_textdomain()` references a custom
 language file that
 [https://buddypress.trac.wordpress.org/browser/tags/2.1/src/bp-core/bp-
 core-functions.php#L1709 never gets loaded] since a language file is
 already in use.

 I think it should be the opposite.  Custom language files (if they exist)
 should take precedence over GlotPress language packs.

 Attached are two approaches to addressing this.

 1. `custom_language_file.patch` - basically reverses the order of
 textdomain checks
 2. `load_plugin_textdomain.patch` - simply uses `load_plugin_textdomain()`
 without the extra parameters since we don't bundle language files in
 `/buddypress/bp-languages` any more.  This means that WP will look at `wp-
 content/plugins/` for the language file first, and then `wp-
 content/languages/plugins` (where the language pack is downloaded).

 The first patch is more backward-compatible.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5887>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac