[buddypress-trac] [BuddyPress Trac] #5884: Inconsistent activation_key update/delete

[buddypress-trac]

#5884: Inconsistent activation_key update/delete
-----------------------------+-------------------
 Reporter:  johnjamesjacoby  |      Owner:
     Type:  defect (bug)     |     Status:  new
 Priority:  high             |  Milestone:  2.1.1
Component:  Members          |    Version:  2.0
 Severity:  normal           |   Keywords:
-----------------------------+-------------------
 In `bp_core_activate_signup()` we use `bp_update_user_meta()` which allows
 the key to be filtered, but in `bp_core_signup_user()` we use
 `update_user_meta()` so this meta can never be overridden.

 I'd like to lobby that we switch the later call to `bp_update_user_meta()`
 both for consistency and flexibility.

 The use-case for per-network activation keys is extremely edge, though...
 I am in the process of implementing something that will use this (similar
 in design to triggering a password reset from WordCamp.org, and not
 wanting to be able to finalize that request through BuddyPress.org.)

 Putting this into 2.1.1 as it's a very small edit that likely does not
 impact any existing installations, but we're so close to 2.1 it doesn't
 feel right to sneak it in.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5884>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac