[buddypress-trac] [BuddyPress Trac] #5876: Unit tests against unclosed tickets not being skipped correctly

buddypress-trac noreply at wordpress.org
Tue Sep 16 01:16:47 UTC 2014

#5876: Unit tests against unclosed tickets not being skipped correctly
 Reporter:  boonebgorges  |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  2.1
Component:  Unit Tests    |    Version:
 Severity:  normal        |   Keywords:
 Marking a unit test with `@ticket BP1234` should cause the test to be
 skipped if ticket 1234 is not closed (unless forcing all tests or running
 that specific test group). This is not currently working, with result that
 the suite is failing on Travis CI and elsewhere.

 The cause appears to be this:

 - We're passing http://buddypress.trac.wordpress.org (non-SSL) to
 `TracTickets::isTracTicketClosed` in BP_UnitTestCase::knownBPbug()
 - When the TracTickets class goes to fetch this content, the wordpress.org
 servers are redirecting away from the non-SSL version to the SSL version
 - During the redirect, the URL-encoded exclamation point in `%21closed` is
 being re-encoded as `%2521closed` (`%25` is a URL-encoded `%`). This
 breaks the `status=!closed` param. Trac doesn't know what to do with the
 invalid `status`, so it returns an empty set of ticket IDs
 - As such, TracTickets thinks that no tickets are unclosed on BP (would
 that this were the case), which means that that open-ticket tests are not
 being skipped

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5876>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list