[buddypress-trac] [BuddyPress Trac] #5856: Activity Stream filters reset when Whats New textbox is clicked
buddypress-trac
noreply at wordpress.org
Wed Sep 3 20:16:35 UTC 2014
#5856: Activity Stream filters reset when Whats New textbox is clicked
--------------------------+-----------------------------
Reporter: Bowromir | Owner:
Type: defect (bug) | Status: new
Priority: low | Milestone: Awaiting Review
Component: Activity | Version: 2.0
Severity: normal | Keywords:
--------------------------+-----------------------------
Since the heartbeat integration there's a few new lines of JS in
buddypress.js that introduces an UX problem. As soon as an user clicks in
the "Whats New" textbox the filters get reset.
{{{
// Return to the 'All Members' tab and 'Everything'
filter,
// to avoid inconsistencies with the heartbeat integration
var $activity_all = jq( '#activity-all' );
if ( $activity_all.length ) {
if ( ! $activity_all.hasClass( 'selected' ) ) {
// reset to everyting
jq( '#activity-filter-select select'
).val( '-1' );
$activity_all.children( 'a' ).trigger(
"click" );
} else if ( '-1' != jq( '#activity-filter-select
select' ).val() ) {
jq( '#activity-filter-select select'
).val( '-1' );
jq( '#activity-filter-select select'
).trigger( 'change' );
}
}
}}}
I've disabled the heartbeat integration to try and prevent this from
happening, but sadly this code still fires. I've removed the code for now,
but it would be nice if this could somehow be fixed or disabled when the
heartbeat integration is disabled.
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5856>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac
More information about the buddypress-trac
mailing list