[buddypress-trac] [BuddyPress Trac] #5958: Add object parameter to bp_core_fetch_avatar_no_grav

buddypress-trac noreply at wordpress.org
Fri Oct 31 13:30:26 UTC 2014


#5958: Add object parameter to bp_core_fetch_avatar_no_grav
----------------------------------------+------------------
 Reporter:  dcavins                     |       Owner:
     Type:  enhancement                 |      Status:  new
 Priority:  low                         |   Milestone:  2.2
Component:  Avatars                     |     Version:  2.1
 Severity:  minor                       |  Resolution:
 Keywords:  has-patch needs-unit-tests  |
----------------------------------------+------------------
Changes (by boonebgorges):

 * keywords:  has-patch => has-patch needs-unit-tests


Comment:

 This looks good at a glance, but: can I be a real pain in the butt and ask
 for one or two unit tests before pulling the trigger? I don't think we
 need exhaustive unit tests for `bp_core_fetch_avatar()` just for the
 purposes of this patch - it would be a huge job - but I would like tests
 that demonstrate that each previously `extract`ed parameter is getting
 correctly parsed to the end of the function. dcavins, could you have a go
 at this?

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5958#comment:4>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list