[buddypress-trac] [BuddyPress Trac] #4017: Group taxonomy

buddypress-trac noreply at wordpress.org
Tue Oct 28 14:26:36 UTC 2014


#4017: Group taxonomy
--------------------------+-----------------------------
 Reporter:  boonebgorges  |       Owner:  boonebgorges
     Type:  enhancement   |      Status:  new
 Priority:  normal        |   Milestone:  Future Release
Component:  Groups        |     Version:
 Severity:  major         |  Resolution:
 Keywords:  has-patch     |
--------------------------+-----------------------------

Comment (by imath):

 So, not being able to edit a tag from the network admin was really
 annoying me!

 I think 4017.03.patch is making it possible without adding too much
 copypasta of {{{edit-tags.php}}} like it was the case in 4017.patch.

 4017.03.patch, i just add some code to handle admin actions before
 including {{{edit-tags.php}}}, see {{{bp_groups_admin_tags_load()}}}
 function. This patch needs javascript to be enabled on the browser, as it
 needs to change some form attributes or inputs. In an ideal world, if
 WordPress was adding filters/actions to :
 - {{{WP_List_Table->search_box()}}} in order to allow us to add a new
 hidden field to hold the page parameter.
 - the action parameter of {{{form#addtag}}} as today it's set to {{{edit-
 tags.php}}} which is not available in network admin.
 - the action parameter of {{{form#edittag}}} in {{{edit-tag-form.php}}} as
 today it's set to {{{edit-tags.php}}} which is not available in network
 admin.

 That said, if javascript is enabled, everything works fine :)

 r-a-y, about :
   array( 'type' => 'tag', 'slug' => 'THE_TAG_SLUG' )

 I'm not sure, as the {{{type}}} parameter is used to filter the order of
 the groups listed (alphabetical, last active...) As a result, when viewing
 the group tags page, changing the orderby dropdown value doesn't sort the
 groups list. Reason why, i've disabled it if on a groups tag page in this
 version of the patch.

 Finally i have a doubt about the way i reset :
 - {{{$wp_query->queried_object}}}
 - and {{{$wp_query->queried_object_id}}}
 to avoid notices when viewing a group tags page.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4017#comment:24>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list