[buddypress-trac] [BuddyPress Trac] #5924: Minor invitation template adjustment
buddypress-trac
noreply at wordpress.org
Thu Oct 16 15:00:42 UTC 2014
#5924: Minor invitation template adjustment
-------------------------------------+------------------
Reporter: dcavins | Owner:
Type: enhancement | Status: new
Priority: low | Milestone: 2.2
Component: Theme | Version: 2.1
Severity: minor | Resolution:
Keywords: has-patch needs-testing |
-------------------------------------+------------------
Comment (by dcavins):
Replying to [comment:1 DJPaul]:
> If someone has modified one template file in their theme, they could end
up with two submit button. I am inclined to think we should leave this
alone unless @dcavins you have a good reason as to why we should make the
change (I acknowledge it's what the template ought to have been like
originally).
Yes, there's the possibility of users having modified one or the other
template parts and getting no submit buttons or two. Happily, that problem
would be somewhat obvious at least.
I have no good reason beyond too much is happening in the AJAX request and
recreating the submit button/nonce could cause heartache if a user is
trying to bind javascript to those DOM objects. That said, it would be
nice to fix but isn't currently breaking anything.
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5924#comment:2>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac
More information about the buddypress-trac
mailing list