[buddypress-trac] [BuddyPress Trac] #5919: Xprofile field meta values not deleted with field

[buddypress-trac]

#5919: Xprofile field meta values not deleted with field
--------------------------+------------------
 Reporter:  tometzky      |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  high          |   Milestone:  2.2
Component:  XProfile      |     Version:  2.1
 Severity:  major         |  Resolution:
 Keywords:  needs-patch   |
--------------------------+------------------

Comment (by boonebgorges):

 > But I'm still not convinced that this is all worth it.

 Perhaps not, but I disagree with your points. Object cache support is
 extremely important in a couple ways:

 1. When querying for a single piece of object metadata, all of that
 object's metadata is loaded into the cache, so that subsequent calls to
 `get_metadata()` on the same pageload do not hit the database
 2. When pulling up a list of items - such as a profile page, where many
 profile fields may be displayed - we prefetch metadata for all xprofile
 objects and store it in the object cache, so that we only run one database
 query instead of many
 3. On sites that have a persistent cache backend, our cache support means
 that calls to `get_metadata()` almost never hit the database

 Using WP's functions for this means that we get support for all of this.
 Previously, we supported none of it.

 I do very much appreciate your thoughts on this issue, and if you'd like
 to continue the discussion and make some suggestions about future
 improvements, please open a separate ticket for it. In the meantime, I'm
 going to go with my suggested fix so that we can get on with the original
 problem of clearing field meta (remember that? :) ).

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5919#comment:10>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac