[buddypress-trac] [BuddyPress Trac] #5923: Can't change size of group thumbnail since 2.1 version

[buddypress-trac]

#5923: Can't change size of group thumbnail since 2.1 version
--------------------------+-----------------------------
 Reporter:  m1000         |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Future Release
Component:  Avatars       |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |
--------------------------+-----------------------------
Changes (by boonebgorges):

 * keywords:   => needs-patch
 * component:  Core => Avatars
 * milestone:  Awaiting Review => Future Release


Comment:

 See #5617 and r8673.

 It was never really possible to customize the size and shape of the crop
 box directly. Before r8673, the cropper was automatically sized to half
 the height and half the width of your image. But we stopped doing that in
 all cases, because it was resulting in a suggested crop size that was
 smaller than the avatar full dimensions, which in turn was resulting in
 upsized avatar images when displayed on profile pages.

 However, now that I look over the changes, it does look like we didn't
 take account of the proportion between height and width, and that appears
 to be what's causing the problem here. In addition, we are casting the
 calculated `$aspect_ratio` to an int, which is also probably part of the
 problem. See 163
 https://buddypress.trac.wordpress.org/browser/tags/2.1/src/bp-core/bp-
 core-cssjs.php#L158

 I guess I'd start the investigation by looking at the aspect ratio, and
 then working backward. It'd be great to get a patch to fix this for 2.2.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5923#comment:1>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac