[buddypress-trac] [BuddyPress Trac] #5918: Add a CSS class to dynamically generated warning messages (was: About warning messages id/classes)

buddypress-trac noreply at wordpress.org
Wed Oct 1 14:42:08 UTC 2014

#5918: Add a CSS class to dynamically generated warning messages
 Reporter:  SGr33n       |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  2.2
Component:  Core         |     Version:
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |
Changes (by boonebgorges):

 * keywords:  needs-patch good-first-bug => has-patch
 * milestone:  Future Release => 2.2


 We'd need to do quite a bit more work to make your proposed changes work
 across themes. For example, we'd need a more theme-independent way to
 determine the vertical offset.

 More broadly, moving some messages to JS-powered flyovers creates some
 fracturing of our UX - these messages are no longer in keeping with our
 non-AJAX-powered messages. I think that we probably can't do this in bp-
 legacy, for backward compatibility reasons. Perhaps as part of a new
 template pack? See https://github.com/karmatosed/buddypress-templates

 But yes, you are right about funky DOM manipulation - using overlays for
 this stuff would simplify that part of our error messaging.

 I don't have a problem adding the requested CSS classes to bp-legacy for
 2.2. Can you verify that 5918.patch will fit the bill? If you would like
 to make a more formal proposal for the fancier changes, please open a new
 ticket and try to provide a cleaned-up patch - your previous patch had a
 couple other miscellaneous fixes.


Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5918#comment:10>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list