[buddypress-trac] [BuddyPress Trac] #5509: invites-loop template re-factoring

buddypress-trac noreply at wordpress.org
Fri Nov 28 19:44:04 UTC 2014

#5509: invites-loop template re-factoring
 Reporter:  hnla                          |       Owner:
     Type:  enhancement                   |      Status:  new
 Priority:  low                           |   Milestone:  2.2
Component:  Theme / Template Parts        |     Version:
 Severity:  minor                         |  Resolution:
 Keywords:  needs-refresh good-first-bug  |

Comment (by hnla):

 5509-2 supersedes all previous patches and refreshes & merges them into

 Patch re-works the approach as described above for checking friends count
 and 'bp_get_new_group_invite_friend_list' out of the invites-loop include
 to the parent file, we check if user has friends, and check friends list
 returns true before calling the invite loop (friends list will return
 false if user has friends  but they are all already members of this group
 thus causing a possible third condition to exist and to check for)

 If we return false on our initial checks we pass over the loop and output
 one of two messages 'have no friends' or all friends are members.

 In the loop if we haven't yet received a selection we display short info
 message  prompting a selection from list, this message removed when
 selection made and invite user loop is generated for display as per
 original behaviour.

 Patch takes into account Boon's concerns with heading tag and drops to h2.

 Minimal styling provided to reduce size of the headings and selector added
 for message block to our message rules to provide a block wrapper styled
 as existing message  elements.

 This is only tested  so far in 2014 and needs running through a few more
 WP standard themes.

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5509#comment:12>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list