[buddypress-trac] [BuddyPress Trac] #6050: Activity admin JS referenceError 'postboxes'
buddypress-trac
noreply at wordpress.org
Fri Nov 28 13:37:44 UTC 2014
#6050: Activity admin JS referenceError 'postboxes'
--------------------------+------------------
Reporter: hnla | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 2.2
Component: Activity | Version:
Severity: normal | Resolution:
Keywords: has-patch |
--------------------------+------------------
Changes (by imath):
* milestone: Awaiting Review => 2.2
Comment:
> I'm not sure really why we need this postbox toggle reset, guess there's
a reason but it's not apparent.
The reason is: as the activity admin is using {{{wp_enqueue_script(
'comment' )}}}, {{{wp-admin/js/comment.js}}} is loaded and sets the
postboxes to the comment screen id
{{{postboxes.add_postbox_toggles('comment');}}} at line 4. Meaning if we
don't reset this, collapse fails and the states are not saved for the
activity screen but the comment screen.
Thanks a lot for the patch, i think it's ok.
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6050#comment:1>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac
More information about the buddypress-trac
mailing list