[buddypress-trac] [BuddyPress Trac] #6013: Allow Group Admins to Unban Members

[buddypress-trac]

#6013: Allow Group Admins to Unban Members
--------------------------+-----------------------------
 Reporter:  skyrie        |       Owner:  DJPaul
     Type:  defect (bug)  |      Status:  assigned
 Priority:  normal        |   Milestone:  Future Release
Component:  Groups        |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |
--------------------------+-----------------------------

Comment (by thebigA):

 When I looked at the source file for the template bp-templates/bp-
 legacy/buddypress/groups/single/admin.php I could see that there was
 already code to allow for a member being banned to be reinstated. This was
 never being processed so I looked to see what records the underlying
 dataset was working on.

 The setting of the check for exclude_banned is in bp-groups-functions.php
 on line 544. This checks to see if the element passed through the
 parameters array is true. The original code had 'exclude_banned=false'
 which was being evaluated as 'false' being a string not a boolean so when
 it got to the test it was always evaluation as true since it was not an
 empty string. Changing the original code to 'exclude_banned=0" is
 evaluating as a boolean so now works as expected.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6013#comment:3>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac