[buddypress-trac] [BuddyPress Trac] #5669: Help plugins to generate activities for their post type(s)

buddypress-trac noreply at wordpress.org
Tue Nov 25 21:09:13 UTC 2014


#5669: Help plugins to generate activities for their post type(s)
-----------------------------------+------------------
 Reporter:  imath                  |       Owner:
     Type:  enhancement            |      Status:  new
 Priority:  normal                 |   Milestone:  2.2
Component:  Activity               |     Version:  2.0
 Severity:  normal                 |  Resolution:
 Keywords:  2nd-opinion has-patch  |
-----------------------------------+------------------

Comment (by boonebgorges):

 Gah, this issue is very minor and annoying :) Under no circumstances
 should we do anything like (3). Another option is to just hook the damn
 thing in two places:

 {{{
 add_action( 'bp_ready', 'foo' );
 add_action( 'admin_init', 'foo' );
 }}}

 This is not beautiful, but it's better IMO than adding another arbitrary
 action. We can come back to the issue at a later date. (I still think my
 lazoloading idea is more elegant, but I don't care enough to argue for it
 anymore.)

 > The only way i see is creating a wrapper function and replace all
 occurrences of buddypress()->activity->actions in the code

 Regardless of what happens with the hooks, we should do this anyway. If
 plugin authors reach directly into the global when we have provided an
 easy-to-use wrapper, then it's their own fault if something breaks in the
 future. It was an oversight not to do it in the first place.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5669#comment:20>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list