[buddypress-trac] [BuddyPress Trac] #5193: More hooks, more power! (in the messages component)

buddypress-trac noreply at wordpress.org
Sat Nov 22 02:02:36 UTC 2014

#5193: More hooks, more power! (in the messages component)
 Reporter:  slaFFik                 |       Owner:
     Type:  enhancement             |      Status:  new
 Priority:  normal                  |   Milestone:  2.2
Component:  Messaging               |     Version:
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |

Comment (by boonebgorges):

 Hi slaFFik, it's me again :) As you can see above, I started working
 through your patch. There is some good stuff in there, but I'm going to
 take a break and pass the ball back to you, with a few comments:

 * For the time being, I'm going to skip all of the suggested changes that
 involve changing the internal logic of a method, until there's unit test
 coverage. If you write the unit tests, it may get done faster ;), but if
 not, I may write them myself. (Some of them already have tests, I think.)
 * You'll see in [9165] that I added documentation for the hooks. Gotta
 have this documentation to put them in.
 * In [9165], you'll see I opted not to use your suggested hooks in
 `populate()`, and replaced them with a single post_populate hook. The
 object gets passed by reference, so someone hooking there can do whatever
 they want to it. Let's try to do a similar consolidation in other areas -
 I would rather add a single hook that allows for many different kinds of
 customization than a half-dozen that are super-specific.

 [attachment:5193.patch] contains all the parts of your last patch that
 have not yet been commited.

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5193#comment:15>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list