[buddypress-trac] [BuddyPress Trac] #5193: More hooks, more power! (in the messages component)

buddypress-trac noreply at wordpress.org
Fri Nov 21 23:02:41 UTC 2014

#5193: More hooks, more power! (in the messages component)
 Reporter:  slaFFik                 |       Owner:
     Type:  enhancement             |      Status:  new
 Priority:  normal                  |   Milestone:  2.2
Component:  Messaging               |     Version:
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |

Comment (by boonebgorges):

 I definitely have no objection to coding standards, but having lots of
 those changes mixed up with new hooks in a single patch makes it harder to
 review. Whether you provide separate patches or not, I will *commit* it
 separately, to keep the changelog clean. If you provide separate patches,
 it will mean less work for me, which means it's more likely to be
 committed sooner :)

 > That will be a pain :(

 It's a bigger pain to deal with regressions!

 If it's a ton of work to split this up into different patches, that's
 fine, but it will just take a bit longer to review and commit, because
 like I said above, I'm going to have to comb through it line by line.
 Thanks for understanding :)

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5193#comment:10>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list