[buddypress-trac] [BuddyPress Trac] #5193: More hooks, more power! (in the messages component)

buddypress-trac noreply at wordpress.org
Fri Nov 21 22:21:26 UTC 2014


#5193: More hooks, more power! (in the messages component)
------------------------------------+------------------
 Reporter:  slaFFik                 |       Owner:
     Type:  enhancement             |      Status:  new
 Priority:  normal                  |   Milestone:  2.2
Component:  Messaging               |     Version:
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |
------------------------------------+------------------
Changes (by slaFFik):

 * keywords:  has-patch => has-patch dev-feedback


Comment:

 There are some places like this:

 {{{
 $this->sender_id = apply_filters(
 'messages_message_sender_id_before_save', $this->sender_id, $this->id );
 $this->thread_id = apply_filters(
 'messages_message_thread_id_before_save', $this->thread_id, $this->id );
 $this->subject   = apply_filters( 'messages_message_subject_before_save',
 $this->subject,   $this->id );
 $this->message   = apply_filters( 'messages_message_content_before_save',
 $this->message,   $this->id );
 $this->date_sent = apply_filters(
 'messages_message_date_sent_before_save', $this->date_sent, $this->id );

 do_action_ref_array( 'messages_message_before_save', array( &$this ) );

 }}}

 which don't require the first part, with individual params filters, as
 everything is covered via `do_action_ref_array` and `&` sign. But as I
 understand, we need to leave this as is for backcompat, right?

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5193#comment:6>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list