[buddypress-trac] [BuddyPress Trac] #6005: No-js bulk deletion of messages

buddypress-trac noreply at wordpress.org
Fri Nov 21 13:04:53 UTC 2014

#6005: No-js bulk deletion of messages
 Reporter:  lakrisgubben                |       Owner:
     Type:  enhancement                 |      Status:  new
 Priority:  normal                      |   Milestone:  2.2
Component:  Messaging                   |     Version:
 Severity:  normal                      |  Resolution:
 Keywords:  needs-refresh dev-feedback  |

Comment (by lakrisgubben):

 >It's unfortunate that you've had to use inconsistent naming conventions
 in the functions you've proposed (_link_formatted() in some places,
 _link() in others),

 Agreed, that that wasn't perfect, but I guess you saw that it was because
 there already existed a (kind of poorly) named function for getting the
 delete-url. :/

 >This is especially true since these functions are just wrappers - they
 don't have any internal logic or accept any arguments. What do you think?
 I'm not sure that having all that in the templates would be so nice (even
 though there's not supermuch logic in them, except for the read/unread
 link). Generally I really like how it's done in the notificatons list. The
 less code in the template-files the better, but that might just be my
 personal opinion. :) And even though I can't right now see any other place
 where these template-tags would be used, you never know in the future. ;)

 Just out of curiosity, why wasn't this approach taken in notifications-

 I'm however fine with making changes to it if you'd prefer that!

 Just so that we're on the same page, you're suggesting something like this
 in messages-loop.php

 <td class="thread-options">
 <?php if ( bp_has_unread_messages() { ?>
 <a class="read" href="<?php bp_mark_message_read_link();?>">read</a>
 <?php } else { ?>
 <a class="unread" href="<?php bp_mark_message_unread_link();?>">unread</a>
 <?php } ?>
 <a class="delete" href="<?php bp_delete_message_link(); ?>">delete</a>

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6005#comment:36>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list