[buddypress-trac] [BuddyPress Trac] #6005: No-js bulk deletion of messages
buddypress-trac
noreply at wordpress.org
Thu Nov 20 11:30:49 UTC 2014
#6005: No-js bulk deletion of messages
----------------------------------------+------------------
Reporter: lakrisgubben | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: 2.2
Component: Messaging | Version:
Severity: normal | Resolution:
Keywords: needs-refresh dev-feedback |
----------------------------------------+------------------
Comment (by lakrisgubben):
@boonebgorges, @hnla: Thanks for the great feedback!
Latest patch removes the width on the <td>´s and add's scope to the
<th>´s. It adds classes to 'from/to' and 'thread-count'.
It also loops through the messages in bulk_management and checks access
and bails before doing the actual bulk management.
It removes some funky whitespace.
>Our general pattern for checking nonces in "action" functions like
bp_messages_action_mark_read() is: check wp_verify_nonce(), and if it
fails, return false out of the function; if it passes, go ahead and do the
logic. In other words, don't bother with bp_core_add_message() and the
redirect if the nonce check fails.
I did this on the bp_messages_action_bulk_manage(). Wasn't sure if you
meant on other places as well Boone.
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6005#comment:31>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac
More information about the buddypress-trac
mailing list