[buddypress-trac] [BuddyPress Trac] #3083: Create message meta table and appropriate meta functions

buddypress-trac noreply at wordpress.org
Thu Nov 20 00:52:15 UTC 2014


#3083: Create message meta table and appropriate meta functions
-------------------------+-----------------------
 Reporter:  r-a-y        |       Owner:  r-a-y
     Type:  enhancement  |      Status:  assigned
 Priority:  normal       |   Milestone:  2.2
Component:  Messaging    |     Version:  1.5
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |
-------------------------+-----------------------
Changes (by r-a-y):

 * keywords:  needs-patch => has-patch
 * owner:   => r-a-y
 * status:  new => assigned
 * milestone:  Future Release => 2.2


Comment:

 First patch for message meta table is up.

 Some notes:
 - Made changes to `BP_Messages_Thread::populate()` to accept a third
 parameter for extra arguments.  For meta purposes, I added an
 `update_meta_cache` argument to mirror the group and activity template
 loops.  Let me know what you think here.
 - Made changes to `BP_Messages_Thread::delete()`.  Most notably to grab
 the `$message_ids` using `$wpdb->get_col()` since a message thread can
 contain more than one message.  Previously, it was using
 `$wpdb->get_var()`, which is wrong.

 In the patch, I've also included oEmbed caching for private messages so
 you can test the functionality, but I'll commit that separately for #5990.

 Also, no unit tests yet, will add that in a subsequent patch.

 Most of this was pretty straightforward due to boonebgorges's awesome work
 with migrating everything over to WP's metadata API.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/3083#comment:7>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list