[buddypress-trac] [BuddyPress Trac] #6005: No-js bulk deletion of messages

buddypress-trac noreply at wordpress.org
Wed Nov 19 16:56:08 UTC 2014


#6005: No-js bulk deletion of messages
----------------------------------------+------------------
 Reporter:  lakrisgubben                |       Owner:
     Type:  enhancement                 |      Status:  new
 Priority:  normal                      |   Milestone:  2.2
Component:  Messaging                   |     Version:
 Severity:  normal                      |  Resolution:
 Keywords:  needs-refresh dev-feedback  |
----------------------------------------+------------------

Comment (by hnla):

 Patch looking great - like the table layout columns condensed, works
 nicely.

 I might suggest a few little enhancements: On the 'From' cells and as much
 as I'm not too fond of overmarking up pcdata think we should wrap the text
 'from' in a classed span just to ensure people can easily target and style
 if necessary (although they could quite easily target the other elements)
 likewise the thread count as class 'thread-count' ? and perhaps with a
 title attr '# messages in this thread' or is that getting a little too
 pedantic?

 >My bad, thought it was ok to post patches from git done with the --no-
 prefix. Latest patch is done through svn, hope it works. :)

 Seems to patch fine although I had to revert some changes in files  but
 more my issue than anything and one was a patch in stylesheet for another
 ticket. Not your bad on the svn/git side of things I think you're in good
 company with the majority of devs who might be issuing the same git style
 patches it's just an issue I ran into before with darned tortoise and
 searching around for resolutions threw up more issues than solutions
 between the two.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6005#comment:27>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list