[buddypress-trac] [BuddyPress Trac] #6025: Add function to send single invitation

buddypress-trac noreply at wordpress.org
Mon Nov 17 20:33:02 UTC 2014


#6025: Add function to send single invitation
-------------------------+------------------
 Reporter:  dcavins      |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  2.2
Component:  Groups       |     Version:
 Severity:  normal       |  Resolution:
 Keywords:  needs-patch  |
-------------------------+------------------
Changes (by boonebgorges):

 * keywords:  has-patch => needs-patch
 * component:  Core => Groups
 * milestone:  Awaiting Review => 2.2


Comment:

 Thanks for this, dcavins. Looks pretty good, but I have a few
 questions/requests:

 * I'd like to see more unit tests for the various failure conditions:
 empty group id, empty invitee id, invited user does not have an invite of
 the right sort, maybe non-existent group/user (though you don't have bail
 conditions for this latter part).
 * Let's return the bool value of `$member->save().
 * I understand why you're reusing the 'groups_send_invites' action, but I
 have mixed feelings about firing it in two different places. Can/should we
 rewrite one of these functions (`groups_send_invites()` or
 `groups_send_invite_by_invitee()`) to use the other one internally?

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6025#comment:1>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list