[buddypress-trac] [BuddyPress Trac] #6022: Buddypress rem font sizing & twentyfifteen theme issues

buddypress-trac noreply at wordpress.org
Mon Nov 17 17:00:40 UTC 2014

#6022: Buddypress rem font sizing  & twentyfifteen theme issues
 Reporter:  hnla                    |      Owner:
     Type:  defect (bug)            |     Status:  new
 Priority:  normal                  |  Milestone:  Awaiting Review
Component:  Theme / Template Parts  |    Version:
 Severity:  normal                  |   Keywords:
 The impending release of Twentyfifteen demonstrates the weakness and
 possible issues that can arise fom BuddyPress stating font sizes too

 In this instance BP states a font-size of font-size: 0.8rem; on a grouped
 ruleset for buttons and other classed elements ( overriding already set
 font sizes in the bp sheet oddly )

 Problem is that at present (2015 is at this date still ?beta)
 twentyfifteen is attempting to use the html body font reduction technique
 to arrive at an easy calculations for setting rem/em sizes at a rounded
 value e.g '1' == 10px '1.4' == 14px and we then are inadvertently saying
 .button(font-size: 0.8rem) or 8px. 8px is below what is considered legible
 and we'll need to do something about this.

 Our options are limited and none are infallible; we could simply not state
 a size and leave that up to themes or devs to handle or we could change to
 using percentage units (my first consideration and which means that we
 would calculate that value from the body size in this instance)

 Any relative measure is however going to have possible issues and is too
 an extent unpredictable as to resulting interpreted size.

 I have seen issues with BP on some themes as we have some percentage units
 lying about and those in the themes suffer from compound errors and are
 computing to be similarly small in size.

 We may have only one safe option in reality, which I mentioned a while
 back, that of using the largely historically neglected 'keywords'.

 Keywords were generally considered unsafe due to the lack of specification
 to computed sizes and thus wide variences amongst browsers, this I believe
 is not such an issue any longer.

 I would suggest we change this BP ruleset to use the keyword 'small' (in
 testing computing to 13px & 'medium' to 16xp & in twentyfourteen is almost
 equal to the size we achieve using 80%)

 ruleset @L761:
 #buddypress button,
 #buddypress a.button,
 #buddypress input[type=submit],
 #buddypress input[type=button],
 #buddypress input[type=reset],
 #buddypress ul.button-nav li a,
 #buddypress div.generic-button a,
 #buddypress .comment-reply-link,
 a.bp-title-button {
         background: #fff; /* Old browsers */
         border: 1px solid #ccc;
         color: #777;
         font-size: .8rem;
         cursor: pointer;
         outline: none;
         padding: 4px 10px;
         text-align: center;
         text-decoration: none;

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6022>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list