[buddypress-trac] [BuddyPress Trac] #6008: Remove HTML from post_title for groups
buddypress-trac
noreply at wordpress.org
Sat Nov 15 17:20:46 UTC 2014
#6008: Remove HTML from post_title for groups
-------------------------------+------------------------------
Reporter: alexander.rohmann | Owner:
Type: defect (bug) | Status: new
Priority: high | Milestone: Awaiting Review
Component: Groups | Version: 2.1
Severity: major | Resolution:
Keywords: |
-------------------------------+------------------------------
Comment (by boonebgorges):
Thanks, imath. I think this general approach is, on balance, the best way
forward. I would like for the other leads to weigh in, so let's make a
note to talk about it during the next dev chat.
Regarding specifics, a couple brief thoughts:
* It would probably be better to make sure that
`bp_legacy_theme_group_create_button()` etc continue to echo the same
value as before. Changing the echoed value so that it's wrapped in an
`<li>` will wreak havoc for others using the button. Maybe a different
function name altogether?
* How about making this change directly in the template instead of using
the bp_groups_directory_group_filter hook? What are the considerations on
each side?
* You changed the section `// Title based on ability to create blogs ` but
I don't get the change - why would the page title ever be 'Create a Site'
on the Sites directory?
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6008#comment:24>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac
More information about the buddypress-trac
mailing list