[buddypress-trac] [BuddyPress Trac] #5513: Bulk Notifications Management
buddypress-trac
noreply at wordpress.org
Tue Nov 11 19:35:36 UTC 2014
#5513: Bulk Notifications Management
---------------------------+---------------------------
Reporter: colabsadmin | Owner: boonebgorges
Type: enhancement | Status: closed
Priority: normal | Milestone: 2.2
Component: Notifications | Version: 2.0
Severity: normal | Resolution: fixed
Keywords: needs-patch |
---------------------------+---------------------------
Comment (by hnla):
@lakrisgubben great patch
> If you're wondering about {{{ #buddypress #notifications-bulk-management
{clear: left;} }}} it's because firefox flipped out if the form wasn't
cleared and put the table to the right of the whole content area. :/
The issue is actually that the BP pagination element sitting in the flow
before the table, and now the form is floated as are it's children, not
really sure why it was floated as it probably ought not to be really,
suspect it was to contain those floated children but overflow or a
clearfix would have been more appropriate, however your 'clear' should be
fine.
As refinement it might be nice to have a little js snippet to trap the
'bulk action' option from being passed - shame really that there still is
no definitive means to adding an option as a label that works cleanly.
Alternatively we could opt(semi pun intended) for using the optgroup
element to carry the string 'Bulk action'
We should though add a label element for the select, it's mandatory really
and we can hide using one of those assistive text classes or add one to
hide the label text.
Ticket #6005 is related, and looking at the messages screens in a similar
vein to notifications.
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5513#comment:12>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac
More information about the buddypress-trac
mailing list