[buddypress-trac] [BuddyPress Trac] #6005: No-js bulk deletion of messages

[buddypress-trac]

#6005: No-js bulk deletion of messages
--------------------------+------------------------------
 Reporter:  lakrisgubben  |       Owner:
     Type:  enhancement   |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Messaging     |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+------------------------------

Comment (by lakrisgubben):

 Replying to [comment:1 boonebgorges]:
 > I think it's used as the AJAX callback for the JS bulk delete (though
 this could use some testing). I guess it's probably fine to reuse it, but
 if so, we'd need some unit tests first to verify that we're not breaking
 the existing functionality. (Looks like you've covered it, but the unit
 tests will increase my confidence.)

 As far as I can tell, the JS
 (https://buddypress.trac.wordpress.org/browser/trunk/src/bp-templates/bp-
 legacy/js/buddypress.js#L1502) uses the function
 bp_legacy_theme_ajax_messages_delete()
 (https://buddypress.trac.wordpress.org/browser/trunk/src/bp-templates/bp-
 legacy/buddypress-functions.php#L1391)

 > The use of the "Delete Selected" link is in keeping with the current JS
 implementation of bulk deletion, but I wonder if we might be a bit bolder
 here: maybe this is an opportunity to bring this interface in line with
 the (IMO far superior) notifications interface. That'd mean:
 >
 > - adding a th row at the top, which would include column headers as well
 as a "Select all" checkbox
 > - adding a "Bulk Actions" dropdown to the bottom of the list (alongside
 "Select")
 > - in "Bulk Actions", have "Delete" in addition to "Mark Read" and "Mark
 Unread"
 >
 > So this ends up being a somewhat more significant overhaul of the
 functionality. What do you think of this? If you like the idea, I might
 ping one or two more people who have thought a lot about messages in the
 past, to get their feedback.

 Totally agree that this'd be nice. Just wasn't sure if there where any
 interest (or if there'd be back-compat concerns) in such a "big" rewrite.
 :) But if you'd like, please get some more people involved and I can see
 what I can do with it.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6005#comment:2>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac