[buddypress-trac] [BuddyPress Trac] #6005: No-js bulk deletion of messages

buddypress-trac noreply at wordpress.org
Tue Nov 11 14:06:21 UTC 2014

#6005: No-js bulk deletion of messages
 Reporter:  lakrisgubben  |      Owner:
     Type:  enhancement   |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  Messaging     |    Version:
 Severity:  normal        |   Keywords:  has-patch
 Currently messages can only be bulk selected/deleted if js is enabled. Not
 only this, but the dropdown for "selecting" messages as well as deleting
 selected messages are visible even if body.no-js.

 This was discussed in #5513 and here's a first attempt at a patch for
 adding no-js support for bulk deletion of messages.

 This patch hides the controls that are dependent on js if body.no-js, and
 moves the checkboxes to the left to be consistent with the notifications
 bulk management and other parts of bp+wp.

 Some things might appear strange in this patch, namely that the <input
 type="submit"> for deleting marked messages is wrapped in a
 <noscript>-tag. I did this to not have to change anything in the
 javascript (which references an <a>-tag) so as to not make things break if
 people roll their own version of buddypress.js.

 I've made use of, and altered a bit, the function
 messages_action_bulk_delete(). I couldn't find any place in BP where this
 function is used, but tried to make sure that it would work as expected if
 used with it's old values... Any feedback on this would be greatly
 appreciated though. Maybe I should write a separate function for this?

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6005>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list